worldcone/forgejo
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
forgejo/templates/repo/commit_status.tmpl

14 lines
473 B
Handlebars
Raw Normal View History

Remove commit status running and warning from the dashboard repo list (#26036) Also added comments so the next time the dashboard repo list won't be forgotten Follows #25839 Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2023-07-21 19:32:25 +09:00
<!-- make sure this matches the color logic in web_src/js/components/DashboardRepoList.vue -->
Remove commit status running and warning to align GitHub (#25839) Fix #25776. Close #25826. In the discussion of #25776, @wolfogre's suggestion was to remove the commit status of `running` and `warning` to keep it consistent with github. references: - https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#about-commit-statuses ## :warning: BREAKING :warning: So the commit status of Gitea will be consistent with GitHub, only `pending`, `success`, `error` and `failure`, while `warning` and `running` are not supported anymore. --------- Co-authored-by: Jason Song <i@wolfogre.com>
2023-07-21 17:24:36 +09:00
{{if eq .State "pending"}}
Fix missing commit status in PR which from forked repo (#23351) close: #23347 ### Reference and Inference According to Github REST API [doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference): 1. The `Drone CI` that can create some commit status by [API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status) is enabled in `go-gitea/gitea`. So I tried to call the API to get a commit status list of a PR which is commited to upstream repo(`go-gitea/gitea`). As a result, the API returned a array of commit status. ![image](https://user-images.githubusercontent.com/33891828/223913371-313d047a-5e2e-484c-b13e-dcd38748703e.png) 2. Then I tried to call the API to get commit status list of the reference which of the `SHA` is the same as step 1 in the repo which is forked from `go-gitea/gitea`. But I got a empty array. ![image](https://user-images.githubusercontent.com/33891828/223930827-17a64d3c-f466-4980-897c-77fe386c4d3b.png) So, I believe it that： 1. The commit status is not shared between upstream repo and forked repo. 2. The coomit status is bound to a repo that performs actions. (Gitea's logic is the same) ### Cause During debugging, I found it that commit status are not stored in the DB as expected. So, I located the following code: https://github.com/go-gitea/gitea/blob/8cadd51bf295e6ff36ac36efed68cc5de34c9382/services/actions/commit_status.go#L18-L26 When I create a PR, the type of `event` is `pull request`, not `push`. So the code return function directly. ### Screenshot ![image](https://user-images.githubusercontent.com/33891828/223939339-dadf539c-1fdd-40c4-96e9-2e4fa733f531.png) ![image](https://user-images.githubusercontent.com/33891828/223939519-edb02bf0-2478-4ea5-9366-be85468f02db.png) ![image](https://user-images.githubusercontent.com/33891828/223939557-ec6f1375-5536-400e-8987-fb7d2fd452fa.png) ### Other In this PR, I also fix the problem of missing icon which represents running in PRs list. ![image](https://user-images.githubusercontent.com/33891828/223939898-2a0339e4-713f-4c7b-9d99-2250a43f3457.png) ![image](https://user-images.githubusercontent.com/33891828/223939979-037a975f-5ced-480c-bac7-0ee00ebfff4b.png)
2023-03-14 06:05:19 +09:00
{{svg "octicon-dot-fill" 18 "commit-status icon text yellow"}}
{{end}}
Display commit status on landing page of repo (#1784) * Display commit status on landing page of repo * improve last status of commits and add link to ci * fix last commit status since the order of ids are desc
2017-09-14 15:51:32 +09:00
{{if eq .State "success"}}
Change commit status icons to SVG (#20736) * Fix commit status popover and switch to svg icons * margin tweak * fix integration, use warning sign for error to match previous * remove fix from here, will be a new pr * use top/bottom positioning * vertically center * use no-entry over alert oction * add exclamation icon * fix test selector * more test fixes
2022-08-10 06:55:29 +09:00
{{svg "octicon-check" 18 "commit-status icon text green"}}
Display commit status on landing page of repo (#1784) * Display commit status on landing page of repo * improve last status of commits and add link to ci * fix last commit status since the order of ids are desc
2017-09-14 15:51:32 +09:00
{{end}}
{{if eq .State "error"}}
Change commit status icons to SVG (#20736) * Fix commit status popover and switch to svg icons * margin tweak * fix integration, use warning sign for error to match previous * remove fix from here, will be a new pr * use top/bottom positioning * vertically center * use no-entry over alert oction * add exclamation icon * fix test selector * more test fixes
2022-08-10 06:55:29 +09:00
{{svg "gitea-exclamation" 18 "commit-status icon text red"}}
Display commit status on landing page of repo (#1784) * Display commit status on landing page of repo * improve last status of commits and add link to ci * fix last commit status since the order of ids are desc
2017-09-14 15:51:32 +09:00
{{end}}
{{if eq .State "failure"}}
Change commit status icons to SVG (#20736) * Fix commit status popover and switch to svg icons * margin tweak * fix integration, use warning sign for error to match previous * remove fix from here, will be a new pr * use top/bottom positioning * vertically center * use no-entry over alert oction * add exclamation icon * fix test selector * more test fixes
2022-08-10 06:55:29 +09:00
{{svg "octicon-x" 18 "commit-status icon text red"}}
Display commit status on landing page of repo (#1784) * Display commit status on landing page of repo * improve last status of commits and add link to ci * fix last commit status since the order of ids are desc
2017-09-14 15:51:32 +09:00
{{end}}
Reference in a new issue Copy permalink