worldcone/forgejo
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix env config parsing for "GITEA____APP_NAME" (#26001)

Browse source 
Regression of #24832 

Fix the bug and add a test for it

Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
wxiaoguang 2023-07-20 17:16:29 +08:00 committed by GitHub
parent d7a8d09da0
commit 28ecac8024
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/setting/config_env.go
View file

@ -86,7 +86,7 @@ func decodeEnvSectionKey(encoded string) (ok bool, section, key string) {
key += remaining key += remaining
} }
section = strings.ToLower(section) section = strings.ToLower(section)
ok = section != "" && key != "" ok = key != ""
if !ok { if !ok {
section = "" section = ""
key = "" key = ""

6
modules/setting/config_env_test.go
View file

@ -48,6 +48,12 @@ func TestDecodeEnvironmentKey(t *testing.T) {
assert.Equal(t, "", key) assert.Equal(t, "", key)
assert.False(t, file) assert.False(t, file)
ok, section, key, file = decodeEnvironmentKey(prefix, suffix, "GITEA____KEY")
assert.True(t, ok)
assert.Equal(t, "", section)
assert.Equal(t, "KEY", key)
assert.False(t, file)
ok, section, key, file = decodeEnvironmentKey(prefix, suffix, "GITEA__SEC__KEY") ok, section, key, file = decodeEnvironmentKey(prefix, suffix, "GITEA__SEC__KEY")
assert.True(t, ok) assert.True(t, ok)
assert.Equal(t, "sec", section) assert.Equal(t, "sec", section)