worldcone/forgejo
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
forgejo/models
History
zeripath 26ef180f46
Correctly rollback in ForkRepository (#17034) 
The rollback functionality in
services/repository/repository.go:ForkRepository is incorrect and could
lead to a deadlock as it uses DeleteRepository to delete the rolled-back
repository - a function which creates its own transaction.

This PR adjusts the rollback function to only use RemoveAll as any
database changes will be automatically rolled-back. It also handles
panics and adjusts the Close within WithTx to ensure that if there is a
panic the session will always be closed.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-14 18:16:40 +02:00
..
fixtures Add repo_id for attachment (#16958) 2021-09-08 17:19:30 +02:00
migrations Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
access.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
access_test.go
action.go Improve notifications for WIP draft PR's (#14663) 2021-06-23 00:14:22 -04:00
action_list.go
action_test.go Clarify the suffices and prefixes of setting.AppSubURL and setting.AppURL (#12999) 2021-02-19 22:36:43 +01:00
admin.go improve empty notice (#15890) 2021-05-16 19:58:26 +08:00
admin_test.go
attachment.go Add repo_id for attachment (#16958) 2021-09-08 17:19:30 +02:00
attachment_test.go Add repo_id for attachment (#16958) 2021-09-08 17:19:30 +02:00
avatar.go Double the avatar size factor (#15941) 2021-05-21 21:18:43 -04:00
avatar_test.go Fix individual tests (addition to #15802) (#15818) 2021-05-12 00:13:42 -04:00
branches.go Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
branches_test.go
commit.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
commit_status.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
commit_status_test.go Fix bug about ListOptions and stars/watchers pagnation (#14556) 2021-02-04 11:23:46 -06:00
consistency.go Update milestone counters on new issue. (#16183) 2021-06-21 14:34:58 -04:00
consistency_test.go Fix orphaned objects deletion bug (#15657) 2021-04-30 20:08:46 +02:00
context.go Correctly rollback in ForkRepository (#17034) 2021-09-14 18:16:40 +02:00
convert.go just add some unit tests (#16291) 2021-06-29 22:00:02 +01:00
error.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
error_oauth2.go
external_login_user.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
fixture_generation.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
fixture_test.go
gpg_key.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
gpg_key_add.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
gpg_key_commit_verification.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
gpg_key_common.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
gpg_key_import.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
gpg_key_test.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
gpg_key_verify.go Add option to provide signature for a token to verify key ownership (#14054) 2021-07-13 15:28:07 +02:00
helper.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
helper_directory.go
helper_environment.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
index.go Add primary_key to issue_index (#16813) 2021-08-25 09:42:51 +01:00
index_test.go Add a new table issue_index to store the max issue index so that issue could be deleted with no duplicated index (#15599) 2021-06-14 10:22:55 +08:00
issue.go Alter issue/comment table TEXT fields to LONGTEXT (#16765) 2021-08-22 23:33:05 +08:00
issue_assignees.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
issue_assignees_test.go Fix individual tests (addition to #15802) (#15818) 2021-05-12 00:13:42 -04:00
issue_comment.go Alter issue/comment table TEXT fields to LONGTEXT (#16765) 2021-08-22 23:33:05 +08:00
issue_comment_list.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
issue_comment_test.go
issue_dependency.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
issue_dependency_test.go
issue_label.go Actually compute proper foreground color for labels (#16729) 2021-08-25 12:55:47 -05:00
issue_label_test.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
issue_list.go Performance improvement for list pull requests (#15447) 2021-04-15 19:34:43 +02:00
issue_list_test.go
issue_lock.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
issue_milestone.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
issue_milestone_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
issue_reaction.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
issue_reaction_test.go
issue_stopwatch.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
issue_stopwatch_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
issue_test.go Add a new table issue_index to store the max issue index so that issue could be deleted with no duplicated index (#15599) 2021-06-14 10:22:55 +08:00
issue_tracked_time.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
issue_tracked_time_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
issue_user.go
issue_user_test.go
issue_watch.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
issue_watch_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
issue_xref.go don't record error when loading ref comment but ref comment id is zero (#15820) 2021-05-11 21:43:35 +01:00
issue_xref_test.go Add a new table issue_index to store the max issue index so that issue could be deleted with no duplicated index (#15599) 2021-06-14 10:22:55 +08:00
lfs.go Code Formats, Nits & Unused Func/Var deletions (#15286) 2021-04-09 09:40:34 +02:00
lfs_lock.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
list_options.go Fix list_options GetStartEnd (#16303) 2021-06-29 22:42:23 +01:00
log.go Fix xorm log stack level (#15285) 2021-04-05 08:41:22 +01:00
login_source.go Fix add authentication page (#16543) 2021-07-25 08:09:52 +01:00
main_test.go
migrate.go Fix delete nonexist oauth application 500 and prevent deadlock (#15384) 2021-04-10 16:49:10 -04:00
models.go Add API Token Cache (#16547) 2021-08-17 14:30:42 -04:00
models_test.go Add test to ensure that dumping of login sources remains correct (#16847) 2021-08-28 04:25:27 +01:00
notification.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
notification_test.go
oauth2.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
oauth2_application.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
oauth2_application_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
org.go Correctly return the number of Repositories for Organizations (#16807) 2021-09-01 01:31:42 -04:00
org_team.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
org_team_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
org_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
project.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
project_board.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
project_issue.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
project_test.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
protected_tag.go Add tag protection (#15629) 2021-06-25 16:28:55 +02:00
protected_tag_test.go Add tag protection (#15629) 2021-06-25 16:28:55 +02:00
pull.go Add option to update pull request by rebase (#16125) 2021-08-31 16:03:45 +02:00
pull_list.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
pull_sign.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
pull_test.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
release.go [API] ListReleases add filter for draft and pre-releases (#16175) 2021-06-17 10:58:10 +02:00
repo.go Add repo_id for attachment (#16958) 2021-09-08 17:19:30 +02:00
repo_activity.go
repo_archiver.go Fix archive error when rename repo or user (#16399) 2021-07-13 14:16:31 +02:00
repo_avatar.go
repo_branch.go
repo_collaboration.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_collaboration_test.go
repo_generate.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_generate_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
repo_indexer.go
repo_issue.go
repo_language_stats.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
repo_list.go not show private user's repo in explore view (#16550) 2021-07-27 00:02:35 +02:00
repo_list_test.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
repo_mirror.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo_permission.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_permission_test.go
repo_pushmirror.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_pushmirror_test.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo_redirect.go Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
repo_redirect_test.go Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
repo_sign.go
repo_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
repo_transfer.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_transfer_test.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
repo_unit.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
repo_watch.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
repo_watch_test.go
review.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
review_test.go Ensure review dismissal only dismisses the correct review (#15477) 2021-04-15 11:03:11 +01:00
session.go Fix DB session cleanup (#15697) 2021-05-01 22:51:03 -04:00
sql_postgres_with_schema.go Ensure that schema search path is set with every connection on postgres (#14131) 2021-01-02 10:07:43 +08:00
ssh_key.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
ssh_key_authorized_keys.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
ssh_key_authorized_principals.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
ssh_key_deploy.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
ssh_key_fingerprint.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
ssh_key_parse.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
ssh_key_principals.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
ssh_key_test.go Add support for ed25519_sk and ecdsa_sk SSH keys (#13462) 2021-01-20 20:36:55 +00:00
star.go
star_test.go
store.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
task.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
test_fixtures.go Create Proper Migration Tests (#15116) 2021-03-24 19:27:22 +01:00
token.go Add API Token Cache (#16547) 2021-08-17 14:30:42 -04:00
token_test.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
topic.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
topic_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
twofactor.go Use single shared random string generation function (#15741) 2021-05-10 07:45:17 +01:00
u2f.go
u2f_test.go
unit.go
unit_tests.go Rework repository archive (#14723) 2021-06-23 17:12:38 -04:00
update.go
upload.go Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 2020-11-27 21:42:08 -05:00
user.go Skip AllowedUserVisibilityModes validation on update user if it is an organisation (#16988) 2021-09-08 17:47:49 +02:00
user_avatar.go Send size to /avatars if requested (#15459) 2021-04-17 00:22:25 +02:00
user_follow.go
user_follow_test.go
user_heatmap.go Fix heatmap activity (#15252) 2021-06-25 12:59:25 -04:00
user_heatmap_test.go Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
user_mail.go Fix activation of primary email addresses (#16385) 2021-07-13 22:59:27 +02:00
user_mail_test.go Always store primary email address into email_address table and also the state (#15956) 2021-06-08 11:52:51 +08:00
user_openid.go Code Formats, Nits & Unused Func/Var deletions (#15286) 2021-04-09 09:40:34 +02:00
user_openid_test.go Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
user_redirect.go Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
user_redirect_test.go Redirect on changed user and org name (#11649) 2021-01-24 16:23:05 +01:00
user_test.go Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
userlist.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
userlist_test.go chore(models): rewrite code format. (#14754) 2021-03-14 19:52:12 +01:00
webhook.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
webhook_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
wiki.go Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 2020-11-27 21:42:08 -05:00
wiki_test.go