forgejo/tests/integration
Earl Warren 603a44edf0
[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments
Refs: https://codeberg.org/forgejo/forgejo/issues/2109
(cherry picked from commit 8b4ba3dce7fc99fa328444ef27383dccca49c237)
(cherry picked from commit 196edea0f972a9a027c4cacb9df36330cf676d2f)

[GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments (squash) do not implicitly create a review

If a comment already exists in a review, the comment is added. If it
is the first comment added to a review, it will implicitly create a
new review instead of adding to the existing one.

The pull_service.CreateCodeComment function is responsibe for this
behavior and it will defer to createCodeComment once the review is
determined, either because it was found or because it was created.

Rename createCodeComment into CreateCodeCommentKnownReviewID to expose
it and change the API endpoint to use it instead. Since the review is
provided by the user and verified to exist already, there is no need
for the logic implemented by CreateCodeComment.

The tests are modified to remove the initial comment from the fixture
because it was creating the false positive. I was verified to fail
without this fix.

(cherry picked from commit 6a555996dca6ba71c65818e14ab0eeafa1af6dc2)
(cherry picked from commit b173a0ccee6cc0dadf40ec55e5d88987314c1cc4)
(cherry picked from commit 838ab9740a6b022676103bcb3a7d168b501006e1)
2024-02-05 16:09:42 +01:00
..
migration-test [DB] run all Forgejo migrations in integration tests 2024-02-05 14:44:33 +01:00
schemas
actions_route_test.go [GITEA] allow viewing the latest Action Run on the web 2024-02-05 16:09:41 +01:00
actions_trigger_test.go Fix schedule tasks bugs (#28691) 2024-01-12 21:50:38 +00:00
admin_config_test.go
admin_user_test.go
api_actions_artifact_test.go Fix uploaded artifacts should be overwritten (#28726) 2024-01-17 11:21:16 +08:00
api_activitypub_person_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_admin_org_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_admin_test.go Unify user update methods (#28733) 2024-02-04 13:29:09 +00:00
api_branch_test.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
api_comment_attachment_test.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
api_comment_test.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
api_feed_plain_text_titles_test.go [GITEA] convert feed items' titles to plain text 2024-02-05 16:09:40 +01:00
api_feed_user_test.go [GITEA] Add repo empty check for branch feed 2024-02-05 16:09:40 +01:00
api_forgejo_root_test.go [API] Forgejo API /api/forgejo/v1 2024-02-05 14:44:32 +01:00
api_forgejo_version_test.go [CLEANUP] Reuse ForgejoVersion variable 2024-02-05 14:45:11 +01:00
api_fork_test.go
api_gitignore_templates_test.go
api_gpg_keys_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_helper_for_declarative_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_httpsig_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_attachment_test.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
api_issue_config_test.go
api_issue_label_test.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
api_issue_milestone_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_pin_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_reaction_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_stopwatch_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_subscription_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_issue_test.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
api_issue_tracked_time_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_keys_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_label_templates_test.go
api_license_templates_test.go
api_nodeinfo_test.go Unify user update methods (#28733) 2024-02-04 13:29:09 +00:00
api_notification_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_oauth2_apps_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_org_avatar_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_org_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_alpine_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_cargo_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_packages_chef_test.go [GITEA] Drop sha256-simd in favor of stdlib 2024-02-05 16:09:40 +01:00
api_packages_composer_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_conan_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_conda_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_container_test.go [GITEA] Drop sha256-simd in favor of stdlib 2024-02-05 16:09:40 +01:00
api_packages_cran_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_debian_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_generic_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_goproxy_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_helm_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_maven_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_npm_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_nuget_test.go [GITEA] feat(nuget): basic manifest download 2024-02-05 15:08:04 +01:00
api_packages_pub_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_pypi_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_rpm_test.go Fix some RPM registry flaws (#28782) 2024-01-19 11:37:10 +00:00
api_packages_rubygems_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_swift_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_packages_test.go [GITEA] Drop sha256-simd in favor of stdlib 2024-02-05 16:09:40 +01:00
api_packages_vagrant_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_private_serv_test.go
api_pull_commits_test.go
api_pull_review_test.go [GITEA] POST /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments 2024-02-05 16:09:42 +01:00
api_pull_test.go [TESTS] add TestAPIForkDifferentName 2024-02-05 14:45:11 +01:00
api_releases_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_archive_test.go Disable query token param in integration tests (#28592) 2023-12-23 11:29:51 +08:00
api_repo_avatar_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_branch_test.go Disable query token param in integration tests (#28592) 2023-12-23 11:29:51 +08:00
api_repo_collaborator_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_edit_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_file_create_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_file_delete_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_file_get_test.go
api_repo_file_helpers.go
api_repo_file_update_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_files_change_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_get_contents_list_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_get_contents_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_git_blobs_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_git_commits_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_git_hook_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_git_notes_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_git_ref_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_git_tags_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
api_repo_git_trees_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_hook_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_languages_test.go [GITEA] Allow user to select email for file operations in Web UI 2024-02-05 16:09:41 +01:00
api_repo_lfs_locks_test.go
api_repo_lfs_migrate_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_lfs_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_raw_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_secrets_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_tags_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_teams_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_repo_test.go [GITEA] Improve HTML title on repositories 2024-02-05 16:05:50 +01:00
api_repo_topic_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_settings_test.go
api_team_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_team_user_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_token_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_twofa_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_avatar_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_email_test.go Unify user update methods (#28733) 2024-02-04 13:29:09 +00:00
api_user_follow_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_heatmap_test.go Refactor timeutil package (#28623) 2023-12-28 10:09:57 +00:00
api_user_info_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_org_perm_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_orgs_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_search_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_secrets_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_star_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
api_user_watch_test.go Add tests for #28765 (#28773) 2024-01-12 17:15:42 +00:00
api_wiki_test.go [GITEA] Optionally allow anyone to edit Wikis 2024-02-05 16:09:42 +01:00
attachment_test.go
auth_ldap_test.go
auth_token_test.go [SECURITY] Rework long-term authentication 2024-02-05 15:06:15 +01:00
avatar.png
benchmarks_test.go
branches_test.go [GITEA] Remove redundant syncBranchToDB 2024-02-05 16:09:42 +01:00
change_default_branch_test.go
cmd_forgejo_actions_test.go [CLI] implement forgejo-cli 2024-02-05 13:33:58 +01:00
cmd_forgejo_test.go [CLI] implement forgejo-cli 2024-02-05 13:33:58 +01:00
cmd_keys_test.go
compare_test.go
cors_test.go Refactor CORS handler (#28587) 2023-12-25 20:13:18 +08:00
create_no_session_test.go
csrf_test.go
db_collation_test.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) 2024-01-10 11:03:23 +00:00
delete_user_test.go
download_test.go
dump_restore_test.go
editor_test.go [GITEA] Allow user to select email for file operations in Web UI 2024-02-05 16:09:41 +01:00
empty_repo_test.go [GITEA] Allow user to select email for file operations in Web UI 2024-02-05 16:09:41 +01:00
eventsource_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
explore_repos_test.go
forgejo_confirmation_repo_test.go [SHARED] make confirmation clearer for dangerous actions 2024-02-05 15:07:49 +01:00
forgejo_git_test.go [GITEA] pulls: "Edit File" button in "Files Changed" tab 2024-02-05 16:09:42 +01:00
git_clone_wiki_test.go
git_helper_for_declarative_test.go Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
git_smart_http_test.go
git_test.go [GITEA] pulls: "Edit File" button in "Files Changed" tab 2024-02-05 16:09:42 +01:00
goget_test.go
gpg_git_test.go
html_helper.go
incoming_email_test.go
integration_test.go [GITEA] Use existing jsonschema library 2024-02-05 16:09:40 +01:00
issue_test.go [GITEA] test GET /{owner}/{repo}/comments/{id}/attachments 2024-02-05 16:09:41 +01:00
lfs_getobject_test.go [GITEA] Use maintained gziphandler 2024-02-05 16:09:40 +01:00
lfs_local_endpoint_test.go
lfs_view_test.go
links_test.go
markup_external_test.go
migrate_test.go Upgrade xorm to new version which supported update join for all supported databases (#28590) 2023-12-31 05:00:35 +00:00
mirror_pull_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
mirror_push_test.go [GITEA] new doctor check: fix-push-mirrors-without-git-remote (#1853) 2024-02-05 16:09:41 +01:00
nonascii_branches_test.go
oauth_test.go [GITEA] oauth2: use link_account page when email/username is missing (#1757) 2024-02-05 16:09:40 +01:00
org_count_test.go
org_project_test.go
org_team_invite_test.go
org_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
private-testing.key
privateactivity_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
project_test.go Do some missing checks (#28423) 2023-12-12 05:01:17 +00:00
pull_compare_test.go
pull_create_test.go [SHARED] make confirmation clearer for dangerous actions 2024-02-05 15:07:49 +01:00
pull_diff_test.go
pull_merge_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
pull_review_test.go
pull_status_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
pull_update_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
README.md Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 (#27337) 2023-10-03 13:27:57 -04:00
README_ZH.md
release_test.go [GITEA] test POST /{username}/{reponame}/{tags,release}/delete 2024-02-05 16:09:41 +01:00
rename_branch_test.go
repo_activity_test.go Retarget depending pulls when the parent branch is deleted (#28686) 2024-01-17 01:44:56 +01:00
repo_badges_test.go [GITEA] Add support for shields.io-based badges 2024-02-05 16:09:42 +01:00
repo_branch_test.go [GITEA] Remove redundant syncBranchToDB 2024-02-05 16:09:42 +01:00
repo_commits_search_test.go Integration Test for Commit Search containing Square Brackets (#28751) 2024-01-11 11:04:45 +08:00
repo_commits_test.go
repo_flags_test.go [FEAT] API support for repository flags 2024-02-05 16:09:42 +01:00
repo_fork_test.go
repo_generate_test.go
repo_mergecommit_revert_test.go Fix reverting a merge commit failing (#28794) 2024-01-16 15:06:51 +00:00
repo_migrate_test.go [GITEA] add GitHub repo migration test 2024-02-05 16:05:50 +01:00
repo_search_test.go Convert to url auth to header auth in tests (#28484) 2023-12-21 23:59:59 +00:00
repo_tag_test.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
repo_test.go [GITEA] Disable the RSS feed in file view for non-branches 2024-02-05 16:09:42 +01:00
repo_topic_test.go
repo_watch_test.go
repofiles_change_test.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
session_test.go Fix session key conflict with database keyword (#28613) 2023-12-27 15:24:23 +08:00
setting_test.go
signin_test.go
signout_test.go
signup_test.go [GITEA] Allow changing the email address before activation 2024-02-05 16:09:41 +01:00
ssh_key_test.go
timetracking_test.go
user_avatar_test.go
user_profile_test.go [GITEA] Find README.md for user profiles case insensitively 2024-02-05 16:09:42 +01:00
user_test.go [GITEA] Fix NPE in UsernameSubRoute 2024-02-05 16:09:41 +01:00
version_test.go
view_test.go
webfinger_test.go
xss_test.go

Integration tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-sqlite
make test-pgsql
make test-mysql
make test-mssql

Make sure to perform a clean build before running tests:

make clean build

Run tests via local act_runner

Run all jobs

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest

Warning: This file defines many jobs, so it will be resource-intensive and therefor not recommended.

Run single job

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest -j <job_name>

You can list all job names via:

act_runner exec -W ./.github/workflows/pull-db-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest -l

Run sqlite integration tests

Start tests

make test-sqlite

Run MySQL integration tests

Setup a MySQL database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:3306 --rm --name mysql mysql:latest #(just ctrl-c to stop db and clean the container)
docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" --rm --name elasticsearch elasticsearch:7.6.0 #(in a second terminal, just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integration tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Run mssql integration tests

Setup a mssql database inside docker

docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSecurePassword1" -p 1433:1433 --rm --name mssql microsoft/mssql-server-linux:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql

Running individual tests

Example command to run GPG test:

For SQLite:

make test-sqlite#GPG

For other databases(replace mssql to mysql, or pgsql):

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG

Setting timeouts for declaring long-tests and long-flushes

We appreciate that some testing machines may not be very powerful and the default timeouts for declaring a slow test or a slow clean-up flush may not be appropriate.

You can either:

  • Within the test ini file set the following section:
[integration-tests]
SLOW_TEST = 10s ; 10s is the default value
SLOW_FLUSH = 5S ; 5s is the default value
  • Set the following environment variables:
GITEA_SLOW_TEST_TIME="10s" GITEA_SLOW_FLUSH_TIME="5s" make test-sqlite