worldcone/forgejo
2
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
forgejo/modules/git
History
wxiaoguang b877504b03
Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266) 
This follows 
* https://github.com/go-gitea/gitea/issues/18553

Introduce `RunWithContextString` and `RunWithContextBytes` to help the refactoring. Add related unit tests. They keep the same behavior to save stderr into err.Error() as `RunInXxx` before.

Remove `RunInDirTimeoutPipeline` `RunInDirTimeoutFullPipeline` `RunInDirTimeout` `RunInDirTimeoutEnv`  `RunInDirPipeline`  `RunInDirFullPipeline`  `RunTimeout`, `RunInDirTimeoutEnvPipeline`, `RunInDirTimeoutEnvFullPipeline`, `RunInDirTimeoutEnvFullPipelineFunc`.

Then remaining `RunInDir` `RunInDirBytes` `RunInDirWithEnv` can be easily refactored in next PR with a simple search & replace:
* before: `stdout, err := RunInDir(path)`
* next: `stdout, _, err := RunWithContextString(&git.RunContext{Dir:path})`

Other changes:
1. When `timeout <= 0`, use default. Because `timeout==0` is meaningless and could cause bugs. And now many functions becomes more simple, eg: `GitGcRepos` 9 lines to 1 line. `Fsck` 6 lines to 1 line.
2. Only set defaultCommandExecutionTimeout when the option `setting.Git.Timeout.Default > 0`
2022-03-31 13:56:22 +02:00
..
pipeline Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
tests/repos rm .sample hooks which aren't used (#19101) 2022-03-16 10:33:07 +00:00
batch_reader.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
blame.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
blame_test.go
blob.go
blob_gogit.go
blob_nogogit.go
blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
command.go Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266) 2022-03-31 13:56:22 +02:00
command_race_test.go Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266) 2022-03-31 13:56:22 +02:00
command_test.go Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266) 2022-03-31 13:56:22 +02:00
commit.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
commit_convert_gogit.go
commit_info.go
commit_info_gogit.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
commit_info_nogogit.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
commit_info_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
commit_reader.go
commit_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
diff.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
diff_test.go
error.go
git.go Refactor git.Command.Run*, introduce RunWithContextString and RunWithContextBytes (#19266) 2022-03-31 13:56:22 +02:00
git_test.go
hook.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
last_commit_cache.go
last_commit_cache_gogit.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
last_commit_cache_nogogit.go
lfs.go Unexport git.GlobalCommandArgs (#18376) 2022-01-25 18:15:58 +00:00
log_name_status.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
notes.go
notes_gogit.go Stop logging an error when notes are not found (#18626) 2022-02-06 15:11:35 +08:00
notes_nogogit.go Stop logging an error when notes are not found (#18626) 2022-02-06 15:11:35 +08:00
notes_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
parse_gogit.go
parse_gogit_test.go
parse_nogogit.go
parse_nogogit_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
README.md
ref.go
remote.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo.go Use a more general (and faster) method to sanitize URLs with credentials (#19239) 2022-03-31 10:25:40 +08:00
repo_archive.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_attribute.go Don't show context cancelled errors in attribute reader (#19006) 2022-03-08 08:30:14 +00:00
repo_attribute_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
repo_base.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_base_gogit.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_base_nogogit.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_blame.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo_blob.go
repo_blob_gogit.go
repo_blob_nogogit.go
repo_blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_branch.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_branch_gogit.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_branch_nogogit.go Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235) 2022-03-29 19:12:33 +02:00
repo_branch_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_commit.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_commit_gogit.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo_commit_nogogit.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo_commit_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_commitgraph.go Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235) 2022-03-29 19:12:33 +02:00
repo_commitgraph_gogit.go
repo_compare.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_compare_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_gpg.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo_hook.go
repo_index.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_language_stats.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
repo_language_stats_gogit.go
repo_language_stats_nogogit.go Prevent dangling GetAttribute calls (#18754) 2022-02-14 18:03:56 +01:00
repo_language_stats_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_object.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_ref.go
repo_ref_gogit.go
repo_ref_nogogit.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_ref_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_stats.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_stats_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tag.go Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235) 2022-03-29 19:12:33 +02:00
repo_tag_gogit.go Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235) 2022-03-29 19:12:33 +02:00
repo_tag_nogogit.go Use full output of git show-ref --tags to get tags for PushUpdateAddTag (#19235) 2022-03-29 19:12:33 +02:00
repo_tag_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tree.go Change git.cmd to RunWithContext (#18693) 2022-02-11 13:47:22 +01:00
repo_tree_gogit.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
repo_tree_nogogit.go Fix NPE on try to get tag reference via API (#18245) 2022-01-12 20:37:46 +00:00
sha1.go
sha1_gogit.go
sha1_nogogit.go
signature.go
signature_gogit.go
signature_nogogit.go
submodule.go
submodule_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tag.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tag_test.go Fix NPE on try to get tag reference via API (#18245) 2022-01-12 20:37:46 +00:00
tree.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
tree_blob.go
tree_blob_gogit.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tree_blob_nogogit.go
tree_entry.go
tree_entry_gogit.go
tree_entry_mode.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tree_entry_nogogit.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
tree_entry_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
tree_gogit.go
tree_nogogit.go Delete old git.NewCommand() and use it as git.NewCommandContext() (#18552) 2022-02-06 20:01:47 +01:00
utils.go
utils_test.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.